pvary commented on code in PR #13056:
URL: https://github.com/apache/iceberg/pull/13056#discussion_r2100598176
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -63,15 +70,8 @@ public static MetricsConfig getDefault() {
return DEFAULT;
}
- /**
- * Creates a metrics config from table configuration.
- *
- * @param props table configuration
- * @deprecated use {@link MetricsConfig#forTable(Table)}
- */
- @Deprecated
- public static MetricsConfig fromProperties(Map<String, String> props) {
- return from(props, null, null);
+ public static MetricsConfig getDefaultForPosDelete() {
Review Comment:
nah.. good point. If we already have a `getDefault`, we can't change that,
and we should conform. This means that your original version was better. Sorry
for the back and forth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
