rdblue commented on a change in pull request #1509:
URL: https://github.com/apache/iceberg/pull/1509#discussion_r496896098
##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
##########
@@ -89,8 +88,18 @@ public Builder table(Table newTable) {
return this;
}
- public Builder filters(List<Expression> newFilters) {
- this.filterExpressions = newFilters;
+ public Builder hadoopConf(Configuration newConf) {
Review comment:
Or maybe this could use the approach from the `FlinkCatalogFactory`:
```java
public static Configuration clusterHadoopConf() {
return
HadoopUtils.getHadoopConfiguration(GlobalConfiguration.loadConfiguration());
}
```
Using `clusterHadoopConf` internally here would avoid the need to expose
this in the API and we could add `Configuration` to the loader later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
