JingsongLi commented on a change in pull request #1509:
URL: https://github.com/apache/iceberg/pull/1509#discussion_r496356236
##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
##########
@@ -89,8 +88,18 @@ public Builder table(Table newTable) {
return this;
}
- public Builder filters(List<Expression> newFilters) {
- this.filterExpressions = newFilters;
+ public Builder hadoopConf(Configuration newConf) {
Review comment:
The reason why Hadoop conf needs to be passed now is because:
- JobManager needs the splits of the scan, so it needs to call
`Table.newScan`.
- So JobManager needs `Table` object, where can a table be generated?
`TableLoader` -> from `Catalog` or `HadoopTables`.
- The creation of `Catalog` and `HadoopTables` needs a Hadoop
`Configuration`.
Maybe we can pass this chain with an Iceberg object (`FileIO` may looks not
good to the creation of catalog)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
