pvary commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r497055066
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -313,6 +327,11 @@ protected void doUnlock(long lockId) throws TException,
InterruptedException {
}
static void validateTableIsIceberg(Table table, String fullName) {
+ if
("TRUE".equalsIgnoreCase(table.getParameters().get(TABLE_CREATION_FROM_HIVE))) {
+ // No check is needed. The table has been created from Hive
(HiveIcebergMetaHook), and we are about to initialize
+ // the Iceberg metadata
+ return;
+ }
Review comment:
`TABLE_TYPE_PROP` is set, but `METADATA_LOCATION_PROP` is not set, and
it would throw the exception. We want to bail out of the checks only if this is
indeed in the table creation phase. In other places I have tried to keep to the
original behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
