rdblue commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r497065523
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -313,6 +327,11 @@ protected void doUnlock(long lockId) throws TException,
InterruptedException {
}
static void validateTableIsIceberg(Table table, String fullName) {
+ if
("TRUE".equalsIgnoreCase(table.getParameters().get(TABLE_CREATION_FROM_HIVE))) {
+ // No check is needed. The table has been created from Hive
(HiveIcebergMetaHook), and we are about to initialize
+ // the Iceberg metadata
+ return;
+ }
Review comment:
Okay, I see. I think I would prefer to simplify this and make it so that
the table is Iceberg if and only if the table property is there. If we don't
have the metadata location, then we can set metadata to null and everything
else should work like normal.
That avoids the need for an extra property, which is a good thing because we
want to keep the `TableOperations` as simple as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
