kbendick commented on a change in pull request #1527:
URL: https://github.com/apache/iceberg/pull/1527#discussion_r497250310
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -100,12 +108,18 @@ protected CatalogLoader createCatalogLoader(String name,
Map<String, String> opt
properties.add(HADOOP_WAREHOUSE_LOCATION);
properties.add(DEFAULT_DATABASE);
properties.add(BASE_NAMESPACE);
+ properties.add(HIVE_SITE_PATH);
return properties;
}
@Override
public Catalog createCatalog(String name, Map<String, String> properties) {
- return createCatalog(name, properties, clusterHadoopConf());
+ Configuration configuration = clusterHadoopConf();
+ String catalogType = properties.get(ICEBERG_CATALOG_TYPE);
+ if (catalogType.equals("hive")) {
Review comment:
Same note here about a named constant for this string literal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
