kbendick commented on a change in pull request #1527:
URL: https://github.com/apache/iceberg/pull/1527#discussion_r498503801
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -52,13 +56,21 @@
// Can not just use "type", it conflicts with CATALOG_TYPE.
public static final String ICEBERG_CATALOG_TYPE = "catalog-type";
+ public static final String ICEBERG_CATALOG_TYPE_HIVE = "hive";
+ public static final String ICEBERG_CATALOG_TYPE_HADOOP = "hadoop";
+
public static final String HIVE_URI = "uri";
public static final String HIVE_CLIENT_POOL_SIZE = "clients";
public static final String HADOOP_WAREHOUSE_LOCATION = "warehouse";
+ public static final String HIVE_SITE_PATH = "hive-site-path";
+ public static final String HIVE_SITE_SCHEMA_FILE = "file";
+ public static final String HIVE_SITE_SCHEMA_HDFS = "hdfs";
Review comment:
I see in your `getSchema` function that the call to the Hadoop fs API
uses `scheme` so I think it is scheme.
```
String schema = path.toUri().getScheme();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
