rdblue commented on a change in pull request #1530:
URL: https://github.com/apache/iceberg/pull/1530#discussion_r497778058
##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java
##########
@@ -525,6 +525,34 @@ public void testVersionHintFileMissingMetadata() throws
Exception {
() -> TABLES.load(tableLocation));
}
+ @Test
+ public void testTableEquality() throws Exception {
Review comment:
Sounds like a good idea. I like to avoid implementing the method in
places where "equals" has a fuzzy definition -- is it the "same" table or is it
an equivalent instance?
We're also relying on `Table.toString` behavior a bit too much. It is
probably time to add `Table.name` to the API and use that instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
