adutra commented on code in PR #12563:
URL: https://github.com/apache/iceberg/pull/12563#discussion_r2177563375
##########
core/src/main/java/org/apache/iceberg/SystemConfigs.java:
##########
@@ -53,6 +53,14 @@ private SystemConfigs() {}
Math.max(2, 4 * Runtime.getRuntime().availableProcessors()),
Integer::parseUnsignedInt);
+ /** Sets the core size of the thread pool used for refreshing authentication
data. */
+ public static final ConfigEntry<Integer> AUTH_REFRESH_THREAD_POOL_SIZE =
+ new ConfigEntry<>(
+ "iceberg.rest.auth.refresh.num-threads",
+ "ICEBERG_AUTH_REFRESH_NUM_THREADS",
+ 1,
Review Comment:
I think 1 is fine. Most of the time, we'll have only 1 auth manager per JVM,
and sometimes 2 (e.g. request signing + credential refreshing) – but
realistically, I think we won't see more than 2 per JVM. Given that the typical
usage of this executor is to schedule token refreshes every hour or so, 1 is
probably fine (also: this is the core pool size, not the maximum pool size).
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
