nastra commented on code in PR #12563:
URL: https://github.com/apache/iceberg/pull/12563#discussion_r2177618295
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -122,9 +123,8 @@ public static void afterClass() throws Exception {
// there aren't other token refreshes being scheduled after every sign
request and after
// TestS3RestSigner completes all tests, there should be only this single
token in the queue
// that is scheduled for refresh
- assertThat(validatingSigner.icebergSigner)
- .extracting("authManager")
- .extracting("refreshExecutor")
+ assertThat(ThreadPools.authRefreshPool())
Review Comment:
I think we should roll back these test changes here and in the other test
class, since nothing really changed in terms of the implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
