stevenzwu commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r2180766445


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -106,6 +107,7 @@ static class DefaultAwsClientFactory implements 
AwsClientFactory {
     @Override
     public S3Client s3() {
       return S3Client.builder()
+          .addPlugin(LegacyMd5Plugin.create())

Review Comment:
   it seems reasonable to make the legacy behavior configurable. wondering what 
should be default? 
   
   I doubt if we need to get the specific configs for 
requestChecksumCalculation/responseChecksumValidation. Keep it a little simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to