stevenzwu commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r2180983308
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -240,6 +248,22 @@ public <T extends AwsClientBuilder> void
applyRetryConfigurations(T builder) {
builder.overrideConfiguration(configBuilder.retryStrategy(RetryMode.ADAPTIVE_V2).build());
}
+ /**
+ * Add a legacy md5 plugin if it is enabled.
+ *
+ * <p>Sample usage:
+ *
+ * <pre>
+ *
S3Client.builder().applyMutation(awsClientProperties::applyLegacyMd5Plugin)
+ * </pre>
+ */
+ @SuppressWarnings("rawtypes")
Review Comment:
Can we update the 3 apple methods to generics like this?
```
public <BuilderT extends AwsClientBuilder<BuilderT, ClientT>, ClientT> void
applyLegacyMd5Plugin(BuilderT builder)
```
that should fix the raw type warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
