singhpk234 commented on code in PR #13449:
URL: https://github.com/apache/iceberg/pull/13449#discussion_r2180994604
##########
core/src/main/java/org/apache/iceberg/rest/ExponentialHttpRequestRetryStrategy.java:
##########
@@ -148,4 +179,14 @@ public TimeValue getRetryInterval(HttpResponse response,
int execCount, HttpCont
return TimeValue.ofMilliseconds(delayMillis + jitter);
}
+
+ private boolean shouldRetryIdempotent(HttpRequest request, int responseCode)
{
+ if (request == null) {
+ return false;
+ }
+
+ // Check if the request is idempotent
+ return Method.isIdempotent(request.getMethod())
+ && idempotentRetriableCodes.contains(responseCode);
Review Comment:
[doubt] why these codes only is this from the rest-spec perspective ? if yes
should we also add these in the above retryReq (we just check idempotency
there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
