RussellSpitzer commented on code in PR #13449:
URL: https://github.com/apache/iceberg/pull/13449#discussion_r2180999905
##########
core/src/main/java/org/apache/iceberg/rest/ExponentialHttpRequestRetryStrategy.java:
##########
@@ -148,4 +179,14 @@ public TimeValue getRetryInterval(HttpResponse response,
int execCount, HttpCont
return TimeValue.ofMilliseconds(delayMillis + jitter);
}
+
+ private boolean shouldRetryIdempotent(HttpRequest request, int responseCode)
{
+ if (request == null) {
+ return false;
+ }
+
+ // Check if the request is idempotent
+ return Method.isIdempotent(request.getMethod())
+ && idempotentRetriableCodes.contains(responseCode);
Review Comment:
My thought was in the above context we haven't gotten any response so we
have no clue what we can retry.
In this method we actually have a response from the server (or something) so
there are many responses we could have gotten that are pointless to retry (not
found, not authorized, etc ...) so I just added a bunch that indicate some sort
of server or network based issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
