pan3793 commented on code in PR #13106:
URL: https://github.com/apache/iceberg/pull/13106#discussion_r2182086335
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java:
##########
@@ -178,6 +184,29 @@ protected InternalRow newInternalRow(Object... values) {
return new GenericInternalRow(values);
}
+ protected static class Result implements LocalScan {
+ private final StructType readSchema;
+ private final InternalRow[] rows;
+
+ public Result(StructType readSchema, InternalRow[] rows) {
+ this.readSchema = readSchema;
+ this.rows = rows;
+ }
+
+ public StructType readSchema() {
+ return this.readSchema;
+ }
+
+ @Override
+ public InternalRow[] rows() {
+ return this.rows;
+ }
+ }
+
+ protected Iterator<Scan> asIteratorScan(StructType readSchema,
InternalRow... rows) {
Review Comment:
sound reasonable, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
