pan3793 commented on code in PR #13106:
URL: https://github.com/apache/iceberg/pull/13106#discussion_r2183558595
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAncestorsOfProcedure.java:
##########
@@ -147,14 +147,16 @@ public void testAncestorOfUsingNamedArgs() {
public void testInvalidAncestorOfCases() {
assertThatThrownBy(() -> sql("CALL %s.system.ancestors_of()", catalogName))
.isInstanceOf(AnalysisException.class)
- .hasMessage("Missing required parameters: [table]");
+ .hasMessage(
+ "[REQUIRED_PARAMETER_NOT_FOUND] Cannot invoke routine
`ancestors_of` because the parameter named `table` is required, but the routine
call did not supply a value. Please update the routine call to supply an
argument value (either positionally at index 0 or by name) and retry the query
again. SQLSTATE: 4274K");
assertThatThrownBy(() -> sql("CALL %s.system.ancestors_of('')",
catalogName))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Cannot handle an empty identifier for parameter 'table'");
assertThatThrownBy(() -> sql("CALL %s.system.ancestors_of('%s', 1.1)",
catalogName, tableIdent))
- .isInstanceOf(AnalysisException.class)
- .hasMessageStartingWith("Wrong arg type for snapshot_id: cannot cast");
+ .isInstanceOf(RuntimeException.class)
Review Comment:
oh, I see your point now, but actually, Spark allows implicit cast from
float to long, so there won't have cast issue.
if I change `1.1` to `'1.1'`, then it throws
```
[CAST_INVALID_INPUT] The value '1.1' of the type "STRING" cannot be cast to
"BIGINT" because it is malformed.
```
not sure my previous question was noticed
https://github.com/apache/iceberg/pull/13106#discussion_r2105812210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
