pvary commented on code in PR #13425:
URL: https://github.com/apache/iceberg/pull/13425#discussion_r2182282088
##########
core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java:
##########
@@ -387,16 +411,21 @@ public void testPartitionStats() throws Exception {
0,
null,
snapshot1.timestampMillis(),
- snapshot1.snapshotId()));
+ snapshot1.snapshotId(),
+ 0));
+
+ DeleteFile posDeletes = null;
+ if (formatVersion >= 3) {
+ posDeletes = commitDVs(testTable, dataFile3);
Review Comment:
Do we want to test that the position delete files and the DV vector counts
are actually aggregated?
Maybe add a positional delete file as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]