nastra commented on code in PR #13425:
URL: https://github.com/apache/iceberg/pull/13425#discussion_r2189459416
##########
core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java:
##########
@@ -696,6 +769,12 @@ private DeleteFile commitPositionDeletes(Table testTable) {
return posDelete;
}
+ private DeleteFile commitDVs(Table testTable, DataFile dataFile) {
Review Comment:
the name is misleading, since it only adds a single DV and not multiple
ones. I don't think it's even worth adding this method, since it is only used
in one single place, so maybe just inline this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
