hsiang-c commented on code in PR #13434:
URL: https://github.com/apache/iceberg/pull/13434#discussion_r2175876377
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogConfig.java:
##########
@@ -28,8 +28,12 @@ public enum SparkCatalogConfig {
"testhive",
SparkCatalog.class.getName(),
ImmutableMap.of(
- "type", "hive",
- "default-namespace", "default")),
+ "type",
+ "hive",
+ "default-namespace",
+ "default",
+ CatalogProperties.CACHE_ENABLED,
+ "false")),
Review Comment:
Which means using `CachingCatalog` in `SparkCatalog` will skip the check
implemented in this PR... looking forward to feedbacks.
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogConfig.java:
##########
@@ -28,8 +28,12 @@ public enum SparkCatalogConfig {
"testhive",
SparkCatalog.class.getName(),
ImmutableMap.of(
- "type", "hive",
- "default-namespace", "default")),
+ "type",
+ "hive",
+ "default-namespace",
+ "default",
+ CatalogProperties.CACHE_ENABLED,
+ "false")),
Review Comment:
Need to disable cache otherwise `CachingCatalog` is used and it doesn't
implement `SupportsNamespaces`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
