hsiang-c commented on code in PR #13434:
URL: https://github.com/apache/iceberg/pull/13434#discussion_r2190804849
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java:
##########
@@ -173,7 +173,7 @@ private void createTable(String newMetadataLocation) throws
SQLException, Interr
if (PropertyUtil.propertyAsBoolean(catalogProperties,
JdbcUtil.STRICT_MODE_PROPERTY, false)
&& !JdbcUtil.namespaceExists(catalogName, connections, namespace)) {
throw new NoSuchNamespaceException(
- "Cannot create table %s in catalog %s. Namespace %s does not exist",
+ "Cannot create table %s in catalog %s. Namespace does not exist: %s",
Review Comment:
Change the error message b/c `CatalogTests.tableCreationWithoutNamespace()`
expects this format.
```java
assertThatThrownBy(
() ->
catalog().buildTable(TableIdentifier.of("non-existing",
"table"), SCHEMA).create())
.isInstanceOf(NoSuchNamespaceException.class)
.hasMessageContaining("Namespace does not exist: non-existing");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
