smaheshwar-pltr commented on PR #2178: URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3048178839
> you could add **kwargs in the TableScan constructor too right as a way to "fix"? Yes, I think you're right. I was a bit hesitant to change the constructor, and also technically subclasses of it would need to take `**kwargs` in their constructors too to avoid this issue themselves which feels easy to miss (though admittedly without #2031 we only have `DataScan` subclassing). But inspection doesn't feel nice either 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
