smaheshwar-pltr commented on PR #2178: URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3057977525
> what if we just filter for only the constructor params? wdyt? Yes, I thought about this and think it's a good idea! We achieve something similar to that too with @jayceslesar's `**kwargs` idea that I think is also worth considering. Was also toying with a polymorphic solution (https://github.com/apache/iceberg-python/pull/2178#discussion_r2198078628) that doesn't assume that `init` parameters and members are named the same for `TableScan`'s subclasses. (Hat-tip to https://github.com/apache/iceberg-python/pull/2178#issuecomment-3048675685) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
