RussellSpitzer commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499798163
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkStructLike.java
##########
@@ -19,11 +19,12 @@
package org.apache.iceberg.spark;
+import java.io.Serializable;
import org.apache.iceberg.StructLike;
import org.apache.iceberg.types.Types;
import org.apache.spark.sql.Row;
-public class SparkStructLike implements StructLike {
+public class SparkStructLike implements StructLike, Serializable {
Review comment:
Yeah they only are serialized going out,
We create a SparkDataFile, pack it into a FileScanTask which becomes a
CombinedScanTask which we then make into a ReadTask which is an InputPartition,
which ends up having to be serialized. (In Spark 3, it's slightly different in
Spark2)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
