rdblue commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499794994
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkStructLike.java
##########
@@ -19,11 +19,12 @@
package org.apache.iceberg.spark;
+import java.io.Serializable;
import org.apache.iceberg.StructLike;
import org.apache.iceberg.types.Types;
import org.apache.spark.sql.Row;
-public class SparkStructLike implements StructLike {
+public class SparkStructLike implements StructLike, Serializable {
Review comment:
Got it. But are those really serialized back? The filtering currently
wraps and filters, but the original `Row` objects are returned to Spark. I
don't think we are serializing `SparkDataFile` if we construct tasks on the
driver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
