nastra commented on code in PR #13507:
URL: https://github.com/apache/iceberg/pull/13507#discussion_r2197772225
##########
core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java:
##########
@@ -51,15 +56,30 @@ public void report(MetricsReport report) {
return;
}
+ executor.submit(() -> {
Review Comment:
My gut feeling is that we shouldn't be retrying here. We don't make any
guarantees about metrics reports and we don't want to cause/surface any issues
in case metrics can't be sent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
