amogh-jahagirdar commented on code in PR #13507:
URL: https://github.com/apache/iceberg/pull/13507#discussion_r2198843241
##########
core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java:
##########
@@ -51,15 +53,17 @@ public void report(MetricsReport report) {
return;
}
- try {
- client.post(
- metricsEndpoint,
- ReportMetricsRequest.of(report),
- null,
- headers,
- ErrorHandlers.defaultErrorHandler());
- } catch (Exception e) {
- LOG.warn("Failed to report metrics to REST endpoint {}",
metricsEndpoint, e);
- }
+ Tasks.range(1)
+ .executeWith(ThreadPools.getWorkerPool())
Review Comment:
I don't think we should be using the worker pool here since that's used for
planning operations. I wouldn't want to possibly interfere with that with
metrics reporting which is basically best effort. Should we just define an
exiting thread pool `metrics-publisher-pool` or something like that and then
just use that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
