rdblue commented on a change in pull request #1525: URL: https://github.com/apache/iceberg/pull/1525#discussion_r500675495
########## File path: spark3/src/main/java/org/apache/iceberg/spark/CreateActions.java ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark; + +import org.apache.spark.sql.SparkSession; +import org.apache.spark.sql.connector.catalog.Identifier; + +public class CreateActions { Review comment: I'm finding it hard to follow when this would migrate a table vs snapshot a table, and it also requires a separate class. Did you consider an API using verbs directly? I'm imagining something like this: ```java Actions.migrate("db.table").execute(); Actions.snapshot("db.table").as("db.table_iceberg").execute() ``` We could add methods as well, but those verbs correspond to the SQL that we expose and we haven't needed anything more complicated than that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
