HeartSaVioR edited a comment on pull request #1559: URL: https://github.com/apache/iceberg/pull/1559#issuecomment-704808370
> - HDFS : The rename fails, no exception is raised. Instead the method call simply returns false. I guess it's not explaining the case when overwrite = true. (If then HDFS is breaking contract. I agree local filesystem is breaking contract without the option so can't simply rely on contract.) delete -> rename would work if we simply do delete regardless of when the file exists or not, so not a big deal though. Just wanted to try to ensure the last one wins, but on concurrent writers it wouldn't be weird anyone wins. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
