rdblue commented on pull request #1559: URL: https://github.com/apache/iceberg/pull/1559#issuecomment-705138872
If there is a rename with overwrite option, then I would prefer to use that for the cases where it _is_ atomic. That would be safer. (Side note: local FS doesn't provide atomic rename, even without overwrite, so you shouldn't be using Hadoop tables with it except for tests.) Also, we don't care whether the version hint is completely up to date. We just want to be close to the real version. Being a version or two behind is okay. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
