nastra commented on code in PR #13590:
URL: https://github.com/apache/iceberg/pull/13590#discussion_r2214974817
##########
core/src/test/java/org/apache/iceberg/TestScanDataFileColumns.java:
##########
@@ -52,9 +50,7 @@ public class TestScanDataFileColumns {
@BeforeEach
public void createTables() throws IOException {
- File location = Files.createTempDirectory(temp, "junit").toFile();
Review Comment:
can you also please update `TestManifestCaching`?
##########
core/src/test/java/org/apache/iceberg/TestManifestWriter.java:
##########
@@ -93,8 +93,7 @@ public void testManifestPartitionStats() throws IOException {
@TestTemplate
public void testWriteManifestWithSequenceNumber() throws IOException {
assumeThat(formatVersion).isGreaterThan(1);
- File manifestFile = File.createTempFile("manifest", ".avro",
temp.toFile());
Review Comment:
I see a few more places around core that use the same pattern. Could you
please update those as well?
<img width="962" height="528" alt="image"
src="https://github.com/user-attachments/assets/9d63742e-ca2e-41bb-bce7-eba58ef8abb0";
/>
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -1371,7 +1371,6 @@ private void assertEqualsRemoveEncryptionKey(
private String createManifestListWithManifestFiles(long snapshotId, Long
parentSnapshotId)
throws IOException {
File manifestList = File.createTempFile("manifests", null, temp.toFile());
Review Comment:
we should also update this one to `File manifestList =
temp.resolve("manifests").toFile();` so that we're doing the same thing across
the codebase
##########
core/src/test/java/org/apache/iceberg/TestManifestWriter.java:
##########
@@ -93,8 +93,7 @@ public void testManifestPartitionStats() throws IOException {
@TestTemplate
public void testWriteManifestWithSequenceNumber() throws IOException {
assumeThat(formatVersion).isGreaterThan(1);
- File manifestFile = File.createTempFile("manifest", ".avro",
temp.toFile());
Review Comment:
can you also please update `DeleteReadTests` in `data`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
