anoopj commented on code in PR #13590:
URL: https://github.com/apache/iceberg/pull/13590#discussion_r2216595962


##########
core/src/test/java/org/apache/iceberg/TestScanDataFileColumns.java:
##########
@@ -52,9 +50,7 @@ public class TestScanDataFileColumns {
 
   @BeforeEach
   public void createTables() throws IOException {
-    File location = Files.createTempDirectory(temp, "junit").toFile();

Review Comment:
   Done



##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -1371,7 +1371,6 @@ private void assertEqualsRemoveEncryptionKey(
   private String createManifestListWithManifestFiles(long snapshotId, Long 
parentSnapshotId)
       throws IOException {
     File manifestList = File.createTempFile("manifests", null, temp.toFile());

Review Comment:
   Done



##########
core/src/test/java/org/apache/iceberg/TestManifestWriter.java:
##########
@@ -93,8 +93,7 @@ public void testManifestPartitionStats() throws IOException {
   @TestTemplate
   public void testWriteManifestWithSequenceNumber() throws IOException {
     assumeThat(formatVersion).isGreaterThan(1);
-    File manifestFile = File.createTempFile("manifest", ".avro", 
temp.toFile());

Review Comment:
   @nastra Done. There were many other tests as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to