xxchan commented on code in PR #1470:
URL: https://github.com/apache/iceberg-rust/pull/1470#discussion_r2221347900
##########
crates/iceberg/src/scan/context.rs:
##########
@@ -262,6 +346,61 @@ impl PlanContext {
field_ids: self.field_ids.clone(),
expression_evaluator_cache:
self.expression_evaluator_cache.clone(),
delete_file_index,
+ filter_fn,
}
}
}
+
+struct Ancestors {
Review Comment:
btw, what kind of validation are you talking about? It seems currently
there's no such thing where `Ancestors` can be used
##########
crates/iceberg/src/scan/context.rs:
##########
@@ -262,6 +346,61 @@ impl PlanContext {
field_ids: self.field_ids.clone(),
expression_evaluator_cache:
self.expression_evaluator_cache.clone(),
delete_file_index,
+ filter_fn,
}
}
}
+
+struct Ancestors {
Review Comment:
btw, what kind of validation are you talking about? It seems currently
there's no such place where `Ancestors` can be used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
