CTTY commented on code in PR #1470:
URL: https://github.com/apache/iceberg-rust/pull/1470#discussion_r2223906620
##########
crates/iceberg/src/scan/context.rs:
##########
@@ -262,6 +346,61 @@ impl PlanContext {
field_ids: self.field_ids.clone(),
expression_evaluator_cache:
self.expression_evaluator_cache.clone(),
delete_file_index,
+ filter_fn,
}
}
}
+
+struct Ancestors {
Review Comment:
Snapshot validation is not implemented yet, I have a [stale
PR](https://github.com/apache/iceberg-rust/pull/1353) for that. My PR also
comes with the logic of scanning ancestors, but I like your version much better
and would love to reuse what you have here when we restart the snapshot
validation work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
