kevinjqliu commented on issue #2123: URL: https://github.com/apache/iceberg-python/issues/2123#issuecomment-3104520590
Thanks for the note @nvartolomei, thats a great point. i found the answer from the java reference implementation https://github.com/apache/iceberg/blob/85cc58aa8acda999926809b3c67bbc3452689490/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java#L116-L129 we should match the behavior for `validAvroName`, `sanitize`, and `ICEBERG_FIELD_NAME_PROP` this is also used on the read side https://github.com/apache/iceberg/blob/85cc58aa8acda999926809b3c67bbc3452689490/core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java#L98-L122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
