nvartolomei commented on issue #2123: URL: https://github.com/apache/iceberg-python/issues/2123#issuecomment-3104601357
I’m still confused about it and would love to see a test (e2e) showing a bug. The Avro projection thingy seems to be related to reading avro files and not parquets. Wonder if it’s some sort of legacy. Parquet doesn’t have issues with special chars in field names. We use field ids rather than the names too. 🤷♂️ On Tue, 22 Jul 2025 at 22:24, Kevin Liu ***@***.***> wrote: > *kevinjqliu* left a comment (apache/iceberg-python#2123) > <https://github.com/apache/iceberg-python/issues/2123#issuecomment-3104520590> > > Thanks for the note @nvartolomei <https://github.com/nvartolomei>, thats > a great point. > > i found the answer from the java reference implementation > > https://github.com/apache/iceberg/blob/85cc58aa8acda999926809b3c67bbc3452689490/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java#L116-L129 > > we should match the behavior for validAvroName, sanitize, and > ICEBERG_FIELD_NAME_PROP > > this is also used on the read side > > https://github.com/apache/iceberg/blob/85cc58aa8acda999926809b3c67bbc3452689490/core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java#L98-L122 > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg-python/issues/2123#issuecomment-3104520590>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAEETWLJZT2QG3R2ISN32OT3J2FW3AVCNFSM6AAAAAB7WNIOIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBUGUZDANJZGA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
