rdblue commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r502072741
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -66,26 +75,31 @@
private ExecutorService executorService;
private TServer server;
private HiveMetaStore.HMSHandler baseHandler;
+ private IMetaStoreClient client = null;
public void start() {
try {
- hiveLocalDir = createTempDirectory("hive",
asFileAttribute(fromString("rwxrwxrwx"))).toFile();
+ this.hiveLocalDir = createTempDirectory("hive",
asFileAttribute(fromString("rwxrwxrwx"))).toFile();
File derbyLogFile = new File(hiveLocalDir, "derby.log");
System.setProperty("derby.stream.error.file",
derbyLogFile.getAbsolutePath());
setupMetastoreDB("jdbc:derby:" + getDerbyPath() + ";create=true");
TServerSocket socket = new TServerSocket(0);
int port = socket.getServerSocket().getLocalPort();
- hiveConf = newHiveConf(port);
- server = newThriftServer(socket, hiveConf);
- executorService = Executors.newSingleThreadExecutor();
- executorService.submit(() -> server.serve());
+ this.hiveConf = newHiveConf(port);
+ this.server = newThriftServer(socket, hiveConf);
+ this.executorService = Executors.newSingleThreadExecutor();
+ this.executorService.submit(() -> server.serve());
+ this.client = new HiveMetaStoreClient(hiveConf);
Review comment:
This might fix the JDK 11 tests, which appear to be failing because of
connections to the Hive metastore. My guess is that the "write error" is that
it times out because the metastore ran out of thread -- and we don't want to
increase those threads.
JDK 8 tests are failing because of a constructor is being used that accepts
a HiveConf. That needs to be done using reflection now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
