rdblue commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r503493394
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -66,26 +72,35 @@
private ExecutorService executorService;
private TServer server;
private HiveMetaStore.HMSHandler baseHandler;
+ private HiveClientPool clientPool;
public void start() {
try {
- hiveLocalDir = createTempDirectory("hive",
asFileAttribute(fromString("rwxrwxrwx"))).toFile();
+ this.hiveLocalDir = createTempDirectory("hive",
asFileAttribute(fromString("rwxrwxrwx"))).toFile();
File derbyLogFile = new File(hiveLocalDir, "derby.log");
System.setProperty("derby.stream.error.file",
derbyLogFile.getAbsolutePath());
setupMetastoreDB("jdbc:derby:" + getDerbyPath() + ";create=true");
TServerSocket socket = new TServerSocket(0);
int port = socket.getServerSocket().getLocalPort();
- hiveConf = newHiveConf(port);
- server = newThriftServer(socket, hiveConf);
- executorService = Executors.newSingleThreadExecutor();
- executorService.submit(() -> server.serve());
+ this.hiveConf = newHiveConf(port);
+ this.server = newThriftServer(socket, hiveConf);
+ this.executorService = Executors.newSingleThreadExecutor();
+ this.executorService.submit(() -> server.serve());
+
+ // in Hive3, setting this as a system prop ensures that it will be
picked up whenever a new HiveConf is created
+ System.setProperty(HiveConf.ConfVars.METASTOREURIS.varname,
hiveConf.getVar(HiveConf.ConfVars.METASTOREURIS));
Review comment:
Why is this needed? It may be nice to use this for applications, but for
testing it seems like this allows us to pass the configuration incorrectly and
still have tests pass. If it isn't needed, I'd rather remove it so that we must
pass configuration properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
