marton-bod opened a new pull request #1570: URL: https://github.com/apache/iceberg/pull/1570
It would be great to increase our Hive test coverage for ORC as well. One way to make progress on that is to run the same StorageHandler tests for both file formats (Parquet and ORC). This would be ideally done by using the JUnit `Parameterized` test runner, however, we're already using the `StandaloneHiveRunner` test runner, so can't use both on the same class. @massdosage are you aware of any easy ways to use HiveRunner without this test runner? Couldn't find any Rules-based implementation for it, and pulling out the logic of the HiveShell initialization from the Runner seemed complicated enough to make it not worth it. Similarly, I didn't find any Rules-based implementation for `Parameterized` either, therefore I had to resort to simply writing new test methods for ORC. It's not elegant, but given the constraints, this comes out to be the least-complicated approach still - and gives us the test coverage we need. I'm happy to use a different approach if you guys have any other ideas on how to make this work in a way that 'scales' better. Thanks! @rdblue @massdosage @pvary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
