massdosage commented on a change in pull request #1570:
URL: https://github.com/apache/iceberg/pull/1570#discussion_r504574338
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerBaseTest.java
##########
@@ -136,18 +136,50 @@ public void after() throws Exception {
}
}
+ // PARQUET
+
+ @Test
+ public void testScanEmptyTableParquet() throws IOException {
Review comment:
I'm afraid this isn't possible with HiveRunner using JUnit4 rules but it
is possible using JUnit5 extensions as this doesn't require a different
extension to be used, the @ParameterizedTest annotation can go at the method
level and then the two play nicely together. So, if/when Iceberg moves to
JUnit5 we could refactor all this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
