zeroshade commented on code in PR #496:
URL: https://github.com/apache/iceberg-go/pull/496#discussion_r2229519974
##########
catalog/internal/utils.go:
##########
@@ -170,7 +170,7 @@ func getDefaultWarehouseLocation(dbname, tablename string,
nsprops, catprops ice
}
if warehousepath := catprops.Get("warehouse", ""); warehousepath != "" {
- return url.JoinPath(warehousepath, dbname+".db", tablename)
+ return url.JoinPath(warehousepath, dbname, tablename)
Review Comment:
as far as I'm aware, iceberg-python unconditionally adds the `.db` suffix,
should we make this an option instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
