laskoviymishka commented on code in PR #496:
URL: https://github.com/apache/iceberg-go/pull/496#discussion_r2229632493
##########
catalog/internal/utils.go:
##########
@@ -170,7 +170,7 @@ func getDefaultWarehouseLocation(dbname, tablename string,
nsprops, catprops ice
}
if warehousepath := catprops.Get("warehouse", ""); warehousepath != "" {
- return url.JoinPath(warehousepath, dbname+".db", tablename)
+ return url.JoinPath(warehousepath, dbname, tablename)
Review Comment:
yeah, make sense to make this conditional, i'll think about how to pass it
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
