kumarpritam863 commented on issue #13593:
URL: https://github.com/apache/iceberg/issues/13593#issuecomment-3116704347
It seems that you have modified this method:
> @Override
public void close(Collection<TopicPartition> closedPartitions) {
stopCoordinator();
stopWorker();
KafkaUtils.seekToLastCommittedOffsets(context);
}
Also " KafkaUtils.seekToLastCommittedOffsets(context);" this call happens
form two places, on sink task close operation
https://github.com/apache/iceberg/blob/f40208ae6fb2f33e578c2637d3dea1db18739f31/kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java#L59
Now since this is close call and this happens only when the task is
initialised and assigned some partition which is being revoked through this
close call, so context cannot be null in that case.
Other invocation happens from this point:
https://github.com/apache/iceberg/blob/f40208ae6fb2f33e578c2637d3dea1db18739f31/kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java#L64
Now in this case if context was null (which also cannot be if you see the
workerSinktask implementation), it would have thrown NPE here itself without
going any further.
Can you point to you current code on GitHub to understand the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
