amogh-jahagirdar commented on code in PR #13697:
URL: https://github.com/apache/iceberg/pull/13697#discussion_r2243805180
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -779,6 +779,22 @@ public void testAddRequiredColumnCaseInsensitive() {
.hasMessage("Cannot add column, name already exists: ID");
}
+ @Test
Review Comment:
Could we also add an explicit test where the initial schema has (id int,
data string) and then we go and try and add `DATA` with case insensitivity? I
know the logic will also catch this case but I think it's good to have that
explicit test since it verifies that our update logic is holistically
evaluating the schema instead of just in incremental fashion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
