riemenschneider commented on code in PR #13697:
URL: https://github.com/apache/iceberg/pull/13697#discussion_r2244011003


##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -779,6 +779,22 @@ public void testAddRequiredColumnCaseInsensitive() {
         .hasMessage("Cannot add column, name already exists: ID");
   }
 
+  @Test

Review Comment:
   The previous test method, testAddRequiredColumnCaseInsensitive(), performs a 
similar test. It starts with a column "id" of type Integer and attempts to add 
another column "ID" of type String, using a case-insensitive comparison of the 
column names.
   
   This test is already in place because conflicts between the existing schema 
and the added columns have been handled correctly.  I have fixed the case where 
two added columns conflict with each other, but not with the existing schema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to