openinx commented on a change in pull request #1477:
URL: https://github.com/apache/iceberg/pull/1477#discussion_r502770301
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFiles.java
##########
@@ -149,6 +160,33 @@ private ManifestFiles() {
throw new UnsupportedOperationException("Cannot write manifest for table
version: " + formatVersion);
}
+ private static org.apache.avro.Schema getManifestAvroSchema() {
Review comment:
Skimmed that pr, looks like we are changing the GenericManifestFile
from an IndexRecord to an Iceberg Record, and use the `DataReader` and
`DataWriter` to accomplish IO. What's the purpose that we turn to Iceberg
record ? For unifying the `IndexRecord` and `Record` and keeping the `Record`
only in future ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
