chenjunjiedada commented on a change in pull request #1477:
URL: https://github.com/apache/iceberg/pull/1477#discussion_r503131058



##########
File path: core/src/main/java/org/apache/iceberg/ManifestFiles.java
##########
@@ -149,6 +160,33 @@ private ManifestFiles() {
     throw new UnsupportedOperationException("Cannot write manifest for table 
version: " + formatVersion);
   }
 
+  private static org.apache.avro.Schema getManifestAvroSchema() {

Review comment:
       Yes, the purpose is to make internal classes not depend on Avro data 
model. After we replace the Avro data mode with Iceberg data model, we could 
refactor two Avro readers and writers as mentioned in 
https://github.com/apache/iceberg/issues/1152.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to