gaborkaszab commented on code in PR #12194:
URL: https://github.com/apache/iceberg/pull/12194#discussion_r2251653936
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -704,4 +714,12 @@ private static TableIdentifier
viewIdentFromPathVars(Map<String, String> pathVar
return TableIdentifier.of(
namespaceFromPathVars(pathVars),
RESTUtil.decodeString(pathVars.get("view")));
}
+
+ private static class ETag {
+ private static final HashFunction MURMUR3 = Hashing.murmur3_32_fixed();
+
+ public static String of(LoadTableResponse resp) {
+ return MURMUR3.hashString(resp.metadataLocation(),
StandardCharsets.UTF_8).toString();
+ }
Review Comment:
I wanted to hide the details of how an ETag is created from the user of the
class, so hence I required the LoadTableResponse as a parameter. Technically
metadataLocation could be enough, but I wanted to hide this, and also in case
we decide to change how ETag is produced, we can do so without changing the
signature of the function. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
