gaborkaszab commented on code in PR #12194:
URL: https://github.com/apache/iceberg/pull/12194#discussion_r2257323520


##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -392,8 +398,9 @@ public <T extends RESTResponse> T handleRequest(
             return castResponse(
                 responseType, CatalogHandlers.stageTableCreate(catalog, 
namespace, request));
           } else {
-            return castResponse(
-                responseType, CatalogHandlers.createTable(catalog, namespace, 
request));
+            LoadTableResponse resp = CatalogHandlers.createTable(catalog, 
namespace, request);
+            responseHeaders.accept(ImmutableMap.of(HttpHeaders.ETAG, 
ETag.of(resp)));

Review Comment:
   I decided to make this pluggable for extra flexibility and for better 
testability in an upcoming PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to