openinx commented on a change in pull request #1565:
URL: https://github.com/apache/iceberg/pull/1565#discussion_r503168802
##########
File path: flink/src/main/java/org/apache/iceberg/flink/IcebergTableSource.java
##########
@@ -68,13 +64,13 @@ public boolean isBounded() {
@Override
public TableSource<RowData> projectFields(int[] fields) {
- return new IcebergTableSource(loader, hadoopConf, schema, options, fields);
+ return new IcebergTableSource(loader, schema, options, fields);
}
@Override
public DataStream<RowData> getDataStream(StreamExecutionEnvironment execEnv)
{
- return
FlinkSource.forRowData().env(execEnv).tableLoader(loader).hadoopConf(hadoopConf)
- .project(getProjectedSchema()).properties(options).build();
+ return
FlinkSource.forRowData().env(execEnv).tableLoader(loader).project(getProjectedSchema())
+ .properties(options).build();
Review comment:
nit: I see somewhere call it `options` and other place call it
`properties`, is it possible to unify them ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
