rdblue commented on a change in pull request #1565:
URL: https://github.com/apache/iceberg/pull/1565#discussion_r502832201
##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -43,18 +44,18 @@ static CatalogLoader hive(String name, Configuration
hadoopConf, String uri, int
class HadoopCatalogLoader implements CatalogLoader {
private final String catalogName;
- private final Configuration hadoopConf;
+ private final SerializableConfiguration hadoopConf;
Review comment:
I'm not an expert on how Flink will run in tests, but I think it would
be safer not to rely on end-to-end or integration tests to check serialization
because there may not be a guarantee that tasks are serialized for those
runners. (And this was a problem for Hive testing in the past.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
